Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in requiring necessary packages #123

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Fix bug in requiring necessary packages #123

merged 1 commit into from
Mar 29, 2024

Conversation

DavdGao
Copy link
Collaborator

@DavdGao DavdGao commented Mar 29, 2024 •
edited
Loading

Description

  1. docstring_parser is used in ServiceFactory, so we move it into mini_requires
  2. add check and warning for necessary packages.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@DavdGao DavdGao linked an issue Mar 29, 2024 that may be closed by this pull request
[Bug]: run conversation_with_react_agent.py occur 'NoneType' object is not callable #120
Closed
@DavdGao DavdGao merged commit 72e179b into modelscope:main Mar 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZiTao-Li ZiTao-Li Awaiting requested review from ZiTao-Li

@qbc2016 qbc2016 Awaiting requested review from qbc2016

@pan-x-c pan-x-c Awaiting requested review from pan-x-c

@rayrayraykk rayrayraykk Awaiting requested review from rayrayraykk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: run conversation_with_react_agent.py occur 'NoneType' object is not callable
1 participant
@DavdGao